Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

Stephen Hemminger wrote:

On Fri, 18 Aug 2006 17:41:26 +0200
Thomas Klein [off-list ref] wrote:

quoted

Hi Alexey,

first of all thanks a lot for the extensive review.


Alexey Dobriyan wrote:

quoted

quoted

+	u64 hret = H_HARDWARE;

Useless assignment here and everywhere.

Initializing returncodes to errorstate is a cheap way to prevent
accidentally returning (uninitalized) success returncodes which
can lead to catastrophic misbehaviour.

That is old thinking. Current compilers do live/dead analysis
and tell you about this at compile time which is better than relying
on default behavior at runtime.

Understood. I reworked the returncode handling and removed the
unnecessary initializations.

Thanks for pointing this out.

Thomas