Re: [2.6.19 PATCH 3/7] ehea: queue management

On Fri, 18 August 2006 15:25:11 +0200, Thomas Klein wrote:

Arjan van de Ven wrote:

quoted

quoted

+	queue->queue_length = nr_of_pages * pagesize;
+	queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));

wow... is this really so large that it warrants a vmalloc()???

Agreed: Replaced with kmalloc()

kzalloc() and you can remove the memset() as well.

Jörn

-- 
Data dominates. If you've chosen the right data structures and organized
things well, the algorithms will almost always be self-evident. Data
structures, not algorithms, are central to programming.
-- Rob Pike