Re: [PATCH 1/6] ehea: interface to network stack

From
Anton Blanchard <hidden>
Date
2006-08-11 20:58:48
Also in
lkml, netdev
Reply to
Jan-Bernd Themann, 2006-08-09
Hi,
quoted hunk ↗ jump to hunk
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c	1969-12-31 
+#define DEB_PREFIX "main"
Doesnt appear to be used.
+static struct net_device_stats *ehea_get_stats(struct net_device *dev)
...
+	cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
I cant see where this gets freed.
quoted hunk ↗ jump to hunk
+
+				skb_index = ((index - i
+					      + port_res->skb_arr_sq_len)
+					     % port_res->skb_arr_sq_len);
This is going to force an expensive divide. Its much better to change
this to the simpler and quicker:

i++;
if (i > max)
	i = 0;

There are a few places in the driver can be changed to do this.
+static int ehea_setup_single_port(struct ehea_adapter *adapter,A
+				  int portnum, struct device_node *dn)
...
+	cb4 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
I cant see where this is freed.

Anton
Thread (13 messages) 13 messages, 7 authors, last reply 2006-08-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help