Re: [PATCH 1/6] ehea: interface to network stack

Hi,

+#define DEB_PREFIX "main"

Doesnt appear to be used.

+static struct net_device_stats *ehea_get_stats(struct net_device *dev)

...

+	cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);

I cant see where this gets freed.

+
+				skb_index = ((index - i
+					      + port_res->skb_arr_sq_len)
+					     % port_res->skb_arr_sq_len);

This is going to force an expensive divide. Its much better to change
this to the simpler and quicker:

i++;
if (i > max)
	i = 0;

There are a few places in the driver can be changed to do this.

+static int ehea_setup_single_port(struct ehea_adapter *adapter,A
+				  int portnum, struct device_node *dn)

...

+	cb4 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);

I cant see where this is freed.

Anton