On Thu, 29 Jun 2006 11:38:04 -0500
Kumar Gala [off-list ref] wrote:

quoted

It removes rtc chip-specific code from the platform code.  It  
accomplishes this by using the new "RTC-framework" glue.

I'm aware of the new RTC framework.

This code seems pretty generic for any RTC using the new framework.   
If so, we should put it somewhere more generic like setup.c

yeah, I'd like to clean up some more of the existing rtc specific code and do that in one fell swoop..

quoted

<snip>

quoted

quoted

diff --git a/include/asm-ppc/mpc83xx.h b/include/asm-ppc/mpc83xx.h
index 02ed2c3..80076be 100644
--- a/include/asm-ppc/mpc83xx.h
+++ b/include/asm-ppc/mpc83xx.h

@@ -25,6 +25,10 @@
 #include <platforms/83xx/mpc834x_sys.h>
 #endif

+#ifdef CONFIG_MPC834x_ITX
+#include <platforms/83xx/mpc834x_itx.h>
+#endif
+

This shouldn't be needed, its a hold over from arch/ppc

Unfortunately it won't build without it.

What's the build error?

..
  CC      arch/powerpc/platforms/83xx/mpc834x_itx.o
arch/powerpc/platforms/83xx/mpc834x_itx.c: In function `mpc83xx_map_irq':
arch/powerpc/platforms/83xx/mpc834x_itx.c:57: error: `PIRQB' undeclared (first use in this function)
..

which reminds me of wanting to adopt Benh's new irq stuff..

Kim