Re: [PATCH] Assume we're on cpu 0 in early boot
From: Michael Ellerman <hidden>
Date: 2006-06-28 02:11:20
Attachments
- signature.asc [application/pgp-signature] 191 bytes
From: Michael Ellerman <hidden>
Date: 2006-06-28 02:11:20
On Wed, 2006-06-28 at 11:42 +1000, Paul Mackerras wrote:
Michael Ellerman writes:quoted
There's a small period early in boot where we don't know which cpu we're running on. That's ok, except that it means we have no paca, or more correctly that our paca pointer points somewhere random. So that we can safely call things like smp_processor_id(), we need a paca, so just assume we're on cpu 0. No code should _write_ to the paca before we've set the correct one up.OK, but why not just do a setup_paca(0) at the start of early_setup(), in C code? You can also remove the redundant paca setting in start_here_common() in head_64.S.
Yep, duh. New patch RSN. cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person