Thread (10 messages) flat view 10 messages, 4 authors, 2006-06-28

Re: [PATCH] convert powermac ide blink to new led infrastructure

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2006-06-27 17:31:31

Looks good. Only one nit: in pmu_led_set(), you should be able to test
if the requested state is identical to the current one and do nothing
without taking the lock no ?

Or does the upper level LED infrastructure takes care of it ?
I don't know, Richard? But yeah, I can do that too.

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help