Thread (10 messages) flat view 10 messages, 4 authors, 2006-06-21

Re: [PATCH] mpic: add support for serial mode interrupts

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-06-21 01:12:36

On Tue, 2006-06-20 at 00:35 +0200, Segher Boessenkool wrote:
quoted
Can you define some constants so others can see just what the bits  
mean
without digging up documentation, instead of just doing magic numbers?
[my favourite argument :-) ]

You'll have to read the documentation to properly understand what
the bit patterns mean anyway.  And if you use symbolic names, you
only add another step: hunting through header files.
Sure, that's why we should remove every symbolic constant in every
driver anywhere in the kernel right ? Sure would help.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help