Thread (9 messages) 9 messages, 2 authors, 2006-06-13

Re: pmf_register_irq_client gives sleep with locks held warning

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-06-10 22:05:09

On Sat, 2006-06-10 at 11:27 +0200, Johannes Berg wrote:
On Sat, 2006-06-10 at 10:03 +1000, Benjamin Herrenschmidt wrote:
quoted
quoted
I don't think your patch is right, it seems to me that now
pmf_unregister_irq_client races against pmf_do_irq: what happens when an
interrupt comes in right in the middle of the list_del()?
Yeah, possibly... too late for 2.6.17 tho.
That's ok, we don't have any in-kernel users anyway. Alas the alsa
people will be dissatisfied because they like to ship new drivers for
old kernels or something. Oh well, I don't care.
We still want people to build out-of-tree for 2.6.17 (please keep the
git there for that), as it will take a while before 2.6.18 is here.

The remaining possible bug in the pmf irq code is probably harmless in
99.99% of the cases in practice :)

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help