Re: [PATCH] powerpc: Fix call to ibm,client-architecture-support
From: Segher Boessenkool <hidden>
Date: 2006-06-07 23:05:48
The code in prom_init.c calling the firmware ibm,client-architecture-support on pSeries has a bug where it fails to properly pass the instance handle of the firmware object when trying to call a method. Result ranges from the call doing nothing to the firmware crashing. (Found by Segher, thanks !)
Dry debugging is one of the most fun things in the world, second only to reverse engineering. Am I pathetic or what?
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Segher Boessenkool <redacted>
quoted hunk ↗ jump to hunk
Index: linux-work/arch/powerpc/kernel/prom_init.c ===================================================================--- linux-work.orig/arch/powerpc/kernel/prom_init.c 2006-05-3013:00:51.000000000 +1000+++ linux-work/arch/powerpc/kernel/prom_init.c 2006-06-0611:59:20.000000000 +1000@@ -822,6 +822,7 @@ static void __init prom_send_capabilitie /* try calling the ibm,client-architecture-support method */ if (call_prom_ret("call-method", 3, 2, &ret, ADDR("ibm,client-architecture-support"), + root, ADDR(ibm_architecture_vec)) == 0) { /* the call exists... */ if (ret)