Re: [Alsa-devel] [RFC 03/12] snd-aoa: add aoa core
From: Takashi Iwai <hidden>
Date: 2006-06-07 18:13:47
At Wed, 07 Jun 2006 15:09:12 +0200, Johannes Berg wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/sound/aoa/core/snd-aoa-gpio-pmf.c
(snip)
+void pmf_handle_notify_irq(void *data)
+{Missing static.
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/sound/aoa/core/snd-aoa-gpio-feature.c
(snip)
+static struct device_node *get_gpio( + char *name, char *altname, int *gpioptr, int *gpioactiveptr)
Unconventional style.
+irqreturn_t ftr_handle_notify_irq(int xx, void *data, struct pt_regs *regs)
+{Missing static.
+static int ftr_set_notify(struct gpio_runtime *rt, + enum notify_type type, + notify_func_t notify, + void *data)
(snip)
+ if (old && !notify) {
+ free_irq(irq, notif);
+ }
+ if (!old && notify) {
+ request_irq(irq, ftr_handle_notify_irq, 0, name, notif);
+ }Remove braces. Any error check from request_irq()? Takashi