Re: [PATCH] powerpc: add dmesg command to xmon
From: Arnd Bergmann <arnd@arndb.de>
Date: 2006-05-28 16:12:15
From: Arnd Bergmann <arnd@arndb.de>
Date: 2006-05-28 16:12:15
On Sunday 28 May 2006 14:07, Olaf Hering wrote:
quoted
This whole function looks fishy to me. It seems unnecessarily rude to me to use kallsyms_lookup_name in order to get at a static variable from another file. Can't you instead add a global function to kernel/printk.c to return the buffer?Its possible, but it wont end up in Linus tree.
Hmm, so the idea is that because Linus doesn't like kernel debuggers, we just obfuscate the code for any improvements to xmon and hope he doesn't notice? Don't get me wrong, I think having dmesg in xmon is a good idea, but this is probably not the best strategy of getting it in there. Arnd <><