On Fri, May 19, 2006 at 10:49:25AM +1000, Michael Ellerman wrote:

On Thu, 2006-05-18 at 17:37 -0700, Mark A. Greer wrote:

quoted

On Thu, May 18, 2006 at 08:47:01AM -0500, Matthew McClintock wrote:

quoted

On Wed, 2006-05-17 at 17:21 -0700, Mark A. Greer wrote:

quoted

+void *
+dt_find_prop_by_name(void *dt_blob, char *full_name, u32 *val_sizep) 

Is there a reason you are not using of_get_flat_dt_prop() instead of
implementing your own version?

Yes.  One is in the kernel, one isn't.  Or, are you asking why I didn't
just copy the kernel code?  If so, I probably should have.

Hrm, we almost need a library of code shared between the kernel &
the bootwrapper.  Sort of illegal but it would save duplicating code
like the flat dt code.

Comments?

Yeah we do. And it's not illegal IMHO as two of our boot wrappers
(prom_init and the iSeries one) are linked with the kernel anyway.

And on all architectures (practically) the zlib inflate code is shared
between kernel and bootstuff.  So it's not unprecidented to do the ugly
define abstractions to let you easily share code as needed.

-- 
Tom Rini