Re: [patch] fix RTC/NVRAM accesses on Maple
From: Hollis Blanchard <hidden>
Date: 2006-05-19 02:25:50
On Fri, 2006-05-19 at 08:58 +1000, Paul Mackerras wrote:
It would look better as:
#ifdef CONFIG_PPC_MAPLE
/* PIBS Version 1.05.0000 04/26/2005 has an incorrect /ht/isa/ranges property.
* The values are bad, and it doesn't even have the right number of cells. */
static void __init fixup_device_tree_maple(void)
{
... etc ...
}
#else
#define fixup_device_tree_maple()
#endif
#if defined(CONFIG_PPC64) && defined(CONFIG_PPC_PMAC)
static void __init fixup_device_tree_pmac(void)
{
... etc ...
}
#else
#define fixup_device_tree_pmac()
#endif
static void __init fixup_device_tree(void)
{
fixup_device_tree_maple();
fixup_device_tree_pmac();
}
Care to redo the patch?If you really think that looks better, sure. :) -Hollis