On Mon, 2006-05-01 at 10:56 +0200, Johannes Berg wrote:

On Mon, 2006-05-01 at 16:58 +1000, Benjamin Herrenschmidt wrote:

quoted

On Fri, 2006-04-28 at 21:15 +0200, Johannes Berg wrote:

quoted

This patch adds an input device for the power button so that userspace gets
notified about the user pressing it via the standard input layer.

Looks interesting. Waht about other buttons/events the PMU can report ?

What else does it report? As far as I know it doesn't have anything
else, at least on my system.

Depends on the machine... earlier ones have the backlight there or
volume control.. then LID close could be an event too...

quoted

quoted

+#define BUS_PMU			0x20

Magic numbers... BAD BAD BAD ... Somebody needs to LART the input layer
people.

It's not really a "magic" number since it doesn't really carry any
information, or would you like string identifiers in each device
descriptor? An enum would be just the same, in fact, the definition
could be rewritten as an enum :)

quoted

Do we need these here ? Why not an initcall self-contained in each
file ?

No heh, good point.

Thanks,
johannes