Re: [PATCH 01/16] ehca: integration in Linuxkernel build system
From: Arnd Bergmann <hidden>
Date: 2006-04-27 11:07:40
Also in:
lkml
On Thursday 27 April 2006 14:05, Heiko J Schick wrote:
Signed-off-by: Heiko J Schick <redacted>
Missing any description whatsoever.
Kconfig | 6 ++++++ Makefile | 29 +++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+)
It would be more practical to put this patch last instead of first so you don't break the build system with partial applies.
quoted hunk ↗ jump to hunk
--- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Kconfig 1970-01-01 01:00:00.000000000 +0100 +++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Kconfig 2006-01-04 16:29:05.000000000 +0100@@ -0,0 +1,6 @@ +config INFINIBAND_EHCA + tristate "eHCA support" + depends on IBMEBUS && INFINIBAND + ---help--- + This is a low level device driver for the IBM + GX based Host channel adapters (HCAs)\ No newline at end of file--- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Makefile 1970-01-01 01:00:00.000000000 +0100 +++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Makefile 2006-03-06 12:26:36.000000000 +0100@@ -0,0 +1,29 @@ +# Authors: Heiko J Schick <schickhj@de.ibm.com> +# Christoph Raisch <raisch@de.ibm.com> +# +# Copyright (c) 2005 IBM Corporation +# +# All rights reserved. +# +# This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD. + +obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o + +hcad_mod-objs = ehca_main.o \ + ehca_hca.o \ + ehca_mcast.o \ + ehca_pd.o \ + ehca_av.o \ + ehca_eq.o \ + ehca_cq.o \ + ehca_qp.o \ + ehca_sqp.o \ + ehca_mrmw.o \ + ehca_reqs.o \ + ehca_irq.o \ + ehca_uverbs.o \ + hcp_if.o \ + hcp_phyp.o \ + ipz_pt_fn.o + +CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL
Do these need to be on the command line? If you always set them anyways, you can probably get rid of the #ifdef checking for them. If you want to keep the code for some reason, it might be better to have a CONFIG_EHCA_USE_HCALL symbol that is set unconditionally from Kconfig. Arnd <><