Re: [PATCH] PowerMac11,2 i2c-bus@0 duplicate dev-tree workaround
From: Michael Ellerman <hidden>
Date: 2006-03-30 22:33:26
On Wed, 2006-03-29 at 13:30 +0200, Johannes Berg wrote:
On a PowerMac11,2, there are two i2c-bus@0 nodes of which only the first is correct. This patch makes the device tree unflattening code ignore the second one on those machines. Signed-Off-By: Johannes Berg <johannes@sipsolutions.net> --- I'm not sure this is the right way to do it. Maybe we should have some 'dev-tree quirks fixer' that makes a third pass through the device tree after the allnodes chain has been set up, and fixes it up. On the other hand, as long as there aren't too many workarounds, this works fine. The patch looks longer than it is because some code changed indentation level.
I don't understand why we need this patch? If we care about getting the "right" node why not check for that where we care? cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person