Re: [PATCH] Fix MPC8548CDS rebooting procedure

On Mar 8, 2006, at 1:24 PM, Haruki Dai-r35557 wrote:

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Wednesday, March 08, 2006 12:33 PM
To: Haruki Dai-r35557
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix MPC8548CDS rebooting procedure


On Mar 8, 2006, at 11:22 AM, Haruki Dai-r35557 wrote:

quoted

This patch fixes the MPC8548 CDS rebooting procedure.
Without this patche, issuing reboot from shell doesn't reboot the
machine.

Signed-off-by: Dai Haruki <redacted>

Dai, I'm avoid taking patches for 85xx that effect new
functionality.  If you want change this to work with
arch/powerpc and make it a run time check for 8548.

Hi Kumar, what kind of new feature is affected by this bug fix? 8548
requires reboot to set the hardware reset bits. The mpc85xx_restart 
() is
not ported to arch/powerpc yet. Which portion of the arch/powerpc code
should be modified in order to restart the machine correctly?
And how do you want me to do run time check? Check SVR?

Restart has never worked properly on the 85xx boards from freescale  
since they never provided a reasonable way to reset the systems in  
software.  So I consider this new functionality at this point.

The powerpc.git tree has an arch/powerpc/platforms/85xx/misc.c that  
has a mpc85xx_restart() in it.

As for run time checking, yes use something like SVR or PVR to  
determine the feature.  In this case its probably best to using  
something like PVR and check for E500r1.  I imagine 8540, 8541, 8555,  
8560 don't support this feature (all e500r1), but all future 8548 and  
newer parts will (e500r2, etc.)

- kumar