On Fri, Mar 24, 2006 at 07:01:38PM +1100, Benjamin Herrenschmidt wrote:

quoted

It would be very useful to print the ppc_md.name of the found machine
here, even without debugging enabled.

Not sure ... without debugging enabled, it's likely that you won't see
anything that early anyway :)

True, but it'd be in the dmesg, and get printed when the console comes up.

quoted

It's really weird that IBM chose to use "chrp" to describe a
PAPR-compliant platform. I guess it's for historical reasons, but it
sure isn't CHRP any more.

Yup, I'm trying to get that changed in the architecture but even if I'm
successful, we'll have to deal with existing machines.

Right, it was mostly a side comment.

quoted

quoted

+      is _not_ "chrp" as this will be matched by the kernel to be a
+      CHRP machine on 32 bits kernel or a pSeries on 64 bits kernels

...or a PAPR-compliant machine on 64-bit kernels.

(Also, "xx-bit kernels", not "xx bits kernels").

yeah yeah :) Thanks for the review anyway !

Hey, I couldn't find much technical issues, so I ended up reading your
comments and picking errors there instead. :-)


-Olof