Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks

On Fri, 2006-01-13 at 00:39 +0100, Michael Hanselmann wrote:

On Thu, Jan 12, 2006 at 10:07:33AM +0100, Vojtech Pavlik wrote:

quoted

I think having it in struct hid_device is safer. We might want to
dynamically allocate only for PowerBook keyboards, though, to save
memory.

These two arrays take 128 Bytes. I don't think it's possible to write
the code to allocate and set them in such short code. Beside of that, it
would affect more code than only hid-input.c, at least hid-core.c would
need modifications, too.

Benjamin Herrenschmidt had the idea of a private field which each device
can use for its own purposes. That's a task for another patch, tough.

This patch implements support for the fn key on Apple PowerBooks using
USB based keyboards.

Dimitri, I think the patch is good enough now and should go in for
2.6.16.

Thanks !
Ben.