Re: [PATCH] Support 8xx based Silicon Turnkey XTc

On Tuesday 06 December 2005 18:01, Wolfgang Denk wrote:

Dear Pantelis,

in message [ref] you wrote:

quoted

Support of Silicon Turnkey's XTc.

Ummm .. a few questions...

quoted

 arch/ppc/platforms/stxxtc.h       |  285 +++++++++++++

Here you include a lot of inlined code, but I have  problems  finding
out  what  it  is  good  for.  For  example,  there  is  a full-blown
bit-banging SPI driver included which is nowhere referenced.

Am I missing something, or should this be cleaned up a bit?

It is used in drivers not submitted at this point...
They'll be forthcoming when the time comes. 
 

quoted

 drivers/mtd/maps/stxxtc_nor.c     |  326 +++++++++++++++

I think it is not a good idea to embed spaces in the flash map names,
as this will make it impossible  to  select  such  devices  from  the
kernel  command  line  which  you  seem  to intend (at least you have
CONFIG_MTD_CMDLINE_PARTS enabled in your default configuration) ?

Well, I guess you're right. Though I never used the kernel command
line for selecting the devices. 

And a design question: Why are  you  using  the  concatenating  (NOR)
flash  driver?  Why don't you simply map the flashes (in U-Boot) such
that you have one contiguous region? That would  make  flash  use  in
U-Boot much more convenient, too.

Unfortunately is not possible. Due to the way the flash is mapped on boot it
is not possible to have it continuous. Believe me I've tried :) 

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Where would we be without rhetorical questions?

Regards

Pantelis