Thread (1 message) 1 message, 1 author, 2005-11-17

Re: gianfar generic PHY assumptions.

From: Matt Porter <mporter@kernel.crashing.org>
Date: 2005-11-17 23:15:00

On Thu, Nov 17, 2005 at 03:50:59PM -0600, David Updegraff wrote:
Hi.

This patch lets gianfar work on 83xx (or 85xx??) boards that have 
Generic PHYs on them that do _NOT_ happen to have an IRQ line wired to 
external_15.  Surely reasonable that if we can't ID the PHY that its 
probably not irq-wired the Freescale-ADS "way"...

It was critical for us; perhaps usefull for others.
Aside from the fact that the patch doesn't apply against the
current kernel due to the change of gianfar to use the phy
layer...why wouldn't you just set the board_flags field
appropriately in your board port? If you don't use a phy interrupt
then don't set the flag claiming that you do.  stx_gp3.c doesn't
make use of the phy interrupt functionality, as an example.

I looked at an older kernel and I'm not sure where you see external
15 being used. It seems to be EXT5 on all the Fscale boards.

-Matt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help