Thread (6 messages) 6 messages, 4 authors, 2005-12-01

Re: [PATCH] ppc boot: replace string labels with numbers

flat view

From: Hollis Blanchard <hidden>
Date: 2005-11-18 15:30:14

On Nov 18, 2005, at 1:42 AM, Olaf Hering wrote:
 On Thu, Nov 17, Jerry Van Baren wrote:
quoted
While I'm being dumb, I gotta ask, how big is zImage and why does 117
bytes make a difference?
Because we can.
quoted
My 2c: if you are going to use inscrutable labels (1,2,3,4), please put
comments in.  At least the previous labels gave hints as to what was
happening.
The code should be obvious.
I hope the above was a joke, Olaf.

I too am wondering where the savings come from. Regardless, IMHO 117 bytes is not a worthwhile tradeoff for less maintainable assembly.

BTW, Jerry, the size of the instructions themselves will not change. I suspect the savings is from things like the symbol table, but I can't replicate it with a simple "hello world" testcase.

-Hollis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help