Re: [PATCH] powerpc: Add support for building uImages
From: Kumar Gala <hidden>
Date: 2005-11-23 19:06:07
Also in:
lkml
From: Kumar Gala <hidden>
Date: 2005-11-23 19:06:07
Also in:
lkml
On Wed, 23 Nov 2005, Sam Ravnborg wrote:
On Wed, Nov 23, 2005 at 12:43:15PM -0600, Kumar Gala wrote:quoted
+ +$(obj)/uImage: $(obj)/vmlinux.gz + $(Q)rm -f $@ + $(call if_changed,uimage) + @echo -n ' Image: $@ ' + @if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fiThe above is suboptimal. The $(call if_changed,uimage) will execute $(cmd_uimage) if 1) prerequisites has changed or 2) the command to execute has changed. In the above case 1) is always true, otherwise we would not reach the statement. So change it to $(call cmd,uimage) is the correct way. The 'bug' is also present in ppc/boot/images
thanks. I'll send a follow up patch to fix both cases. - kumar