Re: [PATCH] ppc32: make sure we have an L3 before touch its control register

On Oct 6, 2005, at 7:33 PM, Benjamin Herrenschmidt wrote:

On Fri, 2005-10-07 at 10:26 +1000, Benjamin Herrenschmidt wrote:

quoted

quoted

Dope, you're right.  I notice that we apparent do this for BTIC and

quoted

quoted

DPM in this function though?

Yes, those bits are buggy. Good catch

And no, in fact, my brain is buggy... On ppc32 we identify first, then
fixup, then only do the call_setup_cpu ! That's why the Idle NAP code
actually goes test the feature bit.

I think ppc64 does it the other way around. ppc64 certainly _requires_
taht the fixup has not yet been applied while running early_setup() as
it may change some CPU features according to firmware properties.

So in the merged kernel, we need to be extra careful here. I think we
should go the ppc64 way actually and apply the fixups later. But that
means fixing the code in cpu_setup_6xx.S indeed.

Well, since we do this early on ppc32, my patch should be ok than. (And is need on 7448, do to some crazyness in how L3CR works on various versions of 7448).

I'd like to see we push this now and worry about "fixing" all of cpu_setup_6xx.S when we move it over to arch/powerpc

- kumar