Re: [PATCH 6/9] powerpc: merge idle_power4.S and fixup traps.c
From: Stephen Rothwell <hidden>
Date: 2005-10-01 02:17:14
Attachments
- (unnamed) [application/pgp-signature] 189 bytes
From: Stephen Rothwell <hidden>
Date: 2005-10-01 02:17:14
On Fri, 30 Sep 2005 15:52:40 -0500 Kumar Gala [off-list ref] wrote:
(My first attempt at posting to the list failed due to size)
Yes, quoting the whole patch was probably not necessary :-)
I really dont like the ideal of splitting up traps.c into traps32.c and traps64.c. This defeats the purpose of the merge. I expect that a significant portion of traps.c is common (or can be made to be) between all powerpc's.
My first attempt at the merge was a real mess and a right pain, so I put the two files in as a compromise. However, I have made another attempt and ,although it took a while, it seems to be going ok. How about we put the two in for now (as that will allow the merge of more platforms to continue) and I will supply a further patch in a few days that combines the two trapsxx.c files? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/