Thread (10 messages) flat view 10 messages, 6 authors, 2005-09-26

Re: [PATCH] powerpc: merged asm/cputable.h

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2005-09-26 23:31:31

quoted
There is a small issue here: You turn identify_cpu into C code. However,
on ppc32, this is called with the kernel not yet relocated (before
prom_init even !). Same with the feature fixup. On ppc32, in order to
run C code that early, it needs to be in -mrelocatable bits of code
(like prom_init) or use RELOC macros (ugh !).
We could keep the bulk of the patch (turn cur_cpu_spec into a struct) but 
still do identify_cpu() in asm, although it would seem like a step backward.
We can do it in C in ppc32 if we use proper RELOC() macros, or do it in
an -mrelocatable piece of code like prom_init (but I'd like to avoid
that).
Do people think it's "better" to have one unified asm implementation, or one 
in asm for ppc32 and one in C for ppc64?
We should only need one implementation for both I suppose.

Ben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help