Thread (2 messages) flat view 2 messages, 2 authors, 2005-08-18
STALE7705d

[PATCH] PPC: Don't sleep in flush_dcache_icache_page()

From: Roland Dreier <hidden>
Date: 2005-08-16 21:06:55
Subsystem: the rest · Maintainer: Linus Torvalds

flush_dcache_icache_page() will be called on an instruction page
fault.  We can't sleep in the fault handler, so use kmap_atomic()
instead of just kmap() for the Book-E case.

Signed-off-by: Roland Dreier <redacted>
diff --git a/arch/ppc/mm/init.c b/arch/ppc/mm/init.c
--- a/arch/ppc/mm/init.c
+++ b/arch/ppc/mm/init.c
@@ -560,8 +560,16 @@ void flush_dcache_page(struct page *page
 void flush_dcache_icache_page(struct page *page)
 {
 #ifdef CONFIG_BOOKE
-	__flush_dcache_icache(kmap(page));
-	kunmap(page);
+	unsigned long flags;
+	void *start;
+
+	local_irq_save(flags);
+
+	start = kmap_atomic(page, KM_PPC_SYNC_PAGE);
+	__flush_dcache_icache(start);
+	kunmap_atomic(start, KM_PPC_SYNC_PAGE);
+
+	local_irq_restore(flags);
 #elif CONFIG_8xx
 	/* On 8xx there is no need to kmap since highmem is not supported */
 	__flush_dcache_icache(page_address(page)); 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help