Re: [PATCH] add field to struct ocp_func_emac_data for platform-specific unsupported PHY features

On Fri, Aug 05, 2005 at 04:26:30PM -0700, Wade Farnsworth wrote:

Could you update this field (and related usages) to be "phy_ftr_exc"?
For "Excluded phy features".  Eugene and I discussed this on IRC and
think it's a better name...for one it starts with the phy_ prefix like
other related phy data. Except for that, it's ready for upstream.

Thanks,
Matt

On Mon, 2005-08-08 at 16:44, Matt Porter wrote:
(snip)

Could you update this field (and related usages) to be "phy_ftr_exc"?
For "Excluded phy features".  Eugene and I discussed this on IRC and
think it's a better name...for one it starts with the phy_ prefix like
other related phy data. Except for that, it's ready for upstream.

Thanks,
Matt

Here is the updated patch with the field renamed to "phy_ftr_exc"
instead of "feat_unsupp".

-Wade Farnsworth

Signed-off-by: Wade Farnsworth <redacted>

On Thu, Aug 11, 2005 at 01:42:07PM -0700, Wade Farnsworth wrote:

[snip]

Please, update OCP_SYSFS_EMAC_DATA() macro as well.

-- 
Eugene

On Sat, Aug 13, 2005 at 12:32:21PM -0700, Eugene Surovegin wrote:

On Thu, Aug 11, 2005 at 01:42:07PM -0700, Wade Farnsworth wrote:

[snip]

quoted

diff -upr linux-2.6/include/asm-ppc/ibm_ocp.h linux-2.6-dev/include/asm-ppc/ibm_ocp.h

--- linux-2.6/include/asm-ppc/ibm_ocp.h	2005-08-11 13:30:02.000000000 -0700
+++ linux-2.6-dev/include/asm-ppc/ibm_ocp.h	2005-08-11 13:12:34.000000000 -0700

@@ -67,6 +67,7 @@ struct ocp_func_emac_data {
 	int	phy_mode;	/* PHY type or configurable mode */
 	u8	mac_addr[6];	/* EMAC mac address */
 	u32	phy_map;	/* EMAC phy map */
+	u32	phy_feat_exc;	/* Excluded PHY features */
 };
 
 /* Sysfs support */

Please, update OCP_SYSFS_EMAC_DATA() macro as well.

Also, I just noticed, Matt suggested different name for this member 
two e-mails ago :)

-- 
Eugene