Thread (12 messages) flat view 12 messages, 4 authors, 2005-08-07

Re: [PATCH] 8xx: add cpm_get_cpmp()

From: Aristeu Sergio Rozanski Filho <hidden>
Date: 2005-08-06 23:42:47

It already is exported, declared as

commproc.h:extern       cpm8xx_t        *cpmp;          /* Pointer to comm processor */


and many drivers use the pointer directly.

arch/ppc/8260_io/ drivers also use the same convention.

Not sure I see much advantage in changing it?
but not with EXPORT_SYMBOL(). I noticed this while compiling i2c stuff
as module. also, I think it's better add a function to do this instead
doing EXPORT_SYMBOL() in a variable.
what you think?

-- 
Aristeu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help