Re: [PATCH] cpm_uart: Made non-console uart work

On Tuesday 02 August 2005 18:24, Vitaly Bordug wrote:

Kumar, Pantelis,

This patch makes non-console UART work on both 8xx and 82xx. Various
issues are resolved:
- removed unnecessary STOP_TX commands in shutdown - no need to
completely stop CPM TX and reinit BDs each time the port is closing;
- when mem_addr has been allocated via dma_coherent_alloc, virt_to_bus
on it will not tell the truth in most cases
- SCC UART needs to wait several character times even after all the BDs
have READY bit cleared
- adds needed board-specific bits for 86xADS

Tested on 8272ADS, 885ADS and 866ADS development boards.
---------------------------------
Signed-off-by:  Vitaly Bordug <redacted>

Vitaly, this patch is clearly in conflict with mine.

Mind taking a look at my patch and include the changes I've made?

You'll only have to change the cpm2cpu & cpu2cpm functions...

I would also argue that the STOP_TX command is needed at shutdown, since
this is the canonical way serial ports operate in linux. Also you might want
to change the protocol running on an SCC port after shutdown.

The rest are fine...

Regards

Pantelis