Andy Fleming [off-list ref] :
[kcalloc]

Should we move the function, then, to include/linux/slab.h?  Or  
somewhere else?

It is already in mm/slab.c

[rc = request_irq(...)]

It appears in drivers/net/*c. Jeff Garzik used to suggest something
similar but it does not matter as long as you do not need to return
an error status (KERN_ERR is probably a bit too strong then).

[initialization of struct phy_setting settings]

#define	NITZ(d,t,s)	{ .speed = s, .duplex = d, .setting = t }

static struct phy_setting settings[] = {
       NITZ(DUPLEX_FULL, SUPPORTED_10000baseT_Full,	10000),
       NITZ(DUPLEX_FULL, SUPPORTED_1000baseT_Full,	SPEED_1000),
       NITZ(DUPLEX_HALF, SUPPORTED_1000baseT_Half,	SPEED_1000),
       NITZ(DUPLEX_FULL, SUPPORTED_100baseT_Full,	SPEED_100),
       NITZ(DUPLEX_HALF, SUPPORTED_100baseT_Half,	SPEED_100),
       NITZ(DUPLEX_FULL, SUPPORTED_10baseT_Full,	SPEED_10),
       NITZ(DUPLEX_HALF, SUPPORTED_10baseT_Half,	SPEED_10),
};

#undef NITZ

--
Ueimor