Thread (5 messages) flat view 5 messages, 2 authors, 2005-07-13

Re: [PATCH] update ppc defconfigs

From: Tom Rini <hidden>
Date: 2005-07-13 18:02:59

On Wed, Jul 13, 2005 at 07:03:51PM +0200, Olaf Hering wrote:
 On Wed, Jul 13, Tom Rini wrote:
quoted
quoted
-CONFIG_LOCALVERSION=""
+CONFIG_LOCALVERSION="common_defconfig"
Please don't do that.  $WHOMEVERs mass-compile-scripts should be setting
this to $WHATEVER.
Will send updated patch.
quoted
quoted
-CONFIG_MODULE_FORCE_UNLOAD=y
+# CONFIG_MODULE_FORCE_UNLOAD is not set
Why?  It looks like you're doing more than running oldconfig here..
That doesnt belong to a default kernel, anyone who wants that can just
enable it.
I disagree, force unload should be the default because it's a handy
'oops, I need to not reboot' thing.

-- 
Tom Rini
http://gate.crashing.org/~trini/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help