Thread (1 message) 1 message, 1 author, 2005-03-28
  • (off-list ancestor, not in this archive)
  • Re: ASM formatting rules? · Matt Porter <mporter@kernel.crashing.org> · 2005-03-28

Re: ASM formatting rules?

From: Matt Porter <mporter@kernel.crashing.org>
Date: 2005-03-28 18:24:59

On Mon, Mar 28, 2005 at 09:56:11AM -0700, Tom Rini wrote:
On Mon, Mar 28, 2005 at 10:44:17AM -0600, Kumar Gala wrote:
quoted
Guys,

While this is not overly important to me, I was wondering if we had any 
rules related to formatting of assembly files.  We seem to have code 
formatted with and without spaces in the args.

I'm assuming something like this (w/o spaces):

<TAB>insn<TAB>argD,arg1,arg2

is what we want?  Just trying to get a rule documented going forward.
My preference is for spaces after each , just because it makes it
visually clearer (and I don't always have instant mental insn->#args
mental mapping :)).
As long as there is <TAG>insn<TAB>, I don't have strong feelings
about the arg spacing.  I feel that spaces between args really
don't enhance readability (why I have none between args in
head_44x.S) but I can live with them.

I think this is a good idea to get some consistency throughout
ppc32 asm.

-Matt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help