Thread (5 messages) 5 messages, 4 authors, 2005-03-30

Re: [PATCH] ppc32: CPM2 PIC cleanup

From: Eugene Surovegin <hidden>
Date: 2005-03-29 20:13:48
Also in: lkml

On Tue, Mar 29, 2005 at 10:42:29AM -0600, Kumar Gala wrote:
Andrew,

Cleaned up the CPM2 interrupt controller code:
* Added the ability to offset the IRQs
* Refactored common PIC init code out of platform files
* Fixed IRQ offsets on MPC85xx so it can handle properly handled multiple 
interrupt controllers (i8259, CPM2 PIC, and OpenPIC)

Signed-off-by: Jason McMullan <redacted>
Signed-off-by: Kumar Gala <redacted>
[snip]

Guys, while you are at it, could we renumber irq_to_siubit[] array in 
cpm2_pic.c so we can get rid of "1 << (31 - bit)" expressions and 
simply use "1 << bit"? I know, it's a minor thing, but you are 
cleaning this stuff anyway, why not make it super clean :).

--
Eugene
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help