Tom,

Here are the only usages of PVR_<CPU> that are in arch/ppc:

boot/simple/misc-ev64260.S:     cmplwi  r25,(PVR_7450 >> 16)
platforms/ev64260.c:    if (pvr !=3D PVR_VER(PVR_7450)) {
platforms/4xx/ebony.c:          case PVR_REV(PVR_440GP_RB):
platforms/4xx/ebony.c:          case PVR_REV(PVR_440GP_RC1):
syslib/ibm440gx_common.c:       if (pvr =3D=3D PVR_440GX_RA || pvr =3D=3D=20=

PVR_440GX_RB ||
syslib/ibm440gx_common.c:           (pvr =3D=3D PVR_440GX_RC && p->cpu >=20=

667000000))

What do you think should we just get ride of all the other cases that=20
are not actually used and leave these in asm/regs.h or should we move=20
them as follows:

PVR_7450 -> into platforms/ev64260.h
PVR_440GP* -> into platforms/4xx/ebony.c (or include/asm/ibm4xx.h)
PVR_440GX* -> into syslib/ibm440gx_common.h

- kumar

On Feb 23, 2005, at 4:52 PM, Kumar Gala wrote:

On Feb 23, 2005, at 4:25 PM, Tom Rini wrote:

quoted

On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:

 >=A0 > Signed-off-by: James Chapman [off-list ref]

quoted

quoted

 > > Trivial patch to add 7447A and 7457 CPU defs.
 >
 > Why?=A0 Most of the PVR definitions here can be removed (*muttering=20=

about
 >=A0 85xx ones being added).

Yeah, yeah, will work on removing them.

- kumar

_______________________________________________
Linuxppc-dev mailing list
 Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev