PATCH: add ppc PVR register values for 7447A and 7457 CPUs

7 messages, 3 authors, 2005-02-24 · open the first message on its own page

PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: James Chapman <jchapman@katalix.com>
Date: 2005-02-23 21:07:15

Signed-off-by: James Chapman <jchapman@katalix.com>

Trivial patch to add 7447A and 7457 CPU defs.

Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: Tom Rini <hidden>
Date: 2005-02-23 22:25:36

On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
Signed-off-by: James Chapman <jchapman@katalix.com>

Trivial patch to add 7447A and 7457 CPU defs.
Why?  Most of the PVR definitions here can be removed (*muttering about
85xx ones being added).

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: Kumar Gala <hidden>
Date: 2005-02-23 22:52:50

On Feb 23, 2005, at 4:25 PM, Tom Rini wrote:
On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
 > Signed-off-by: James Chapman [off-list ref]
quoted
Trivial patch to add 7447A and 7457 CPU defs.
Why?=A0 Most of the PVR definitions here can be removed (*muttering =
about
 85xx ones being added).
Yeah, yeah, will work on removing them.

- kumar

Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: Kumar Gala <hidden>
Date: 2005-02-24 05:16:38

Tom,

Here are the only usages of PVR_<CPU> that are in arch/ppc:

boot/simple/misc-ev64260.S:     cmplwi  r25,(PVR_7450 >> 16)
platforms/ev64260.c:    if (pvr !=3D PVR_VER(PVR_7450)) {
platforms/4xx/ebony.c:          case PVR_REV(PVR_440GP_RB):
platforms/4xx/ebony.c:          case PVR_REV(PVR_440GP_RC1):
syslib/ibm440gx_common.c:       if (pvr =3D=3D PVR_440GX_RA || pvr =3D=3D=20=

PVR_440GX_RB ||
syslib/ibm440gx_common.c:           (pvr =3D=3D PVR_440GX_RC && p->cpu >=20=

667000000))

What do you think should we just get ride of all the other cases that=20
are not actually used and leave these in asm/regs.h or should we move=20
them as follows:

PVR_7450 -> into platforms/ev64260.h
PVR_440GP* -> into platforms/4xx/ebony.c (or include/asm/ibm4xx.h)
PVR_440GX* -> into syslib/ibm440gx_common.h

- kumar

On Feb 23, 2005, at 4:52 PM, Kumar Gala wrote:

On Feb 23, 2005, at 4:25 PM, Tom Rini wrote:
quoted
On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
 >=A0 > Signed-off-by: James Chapman [off-list ref]
quoted
quoted
 > > Trivial patch to add 7447A and 7457 CPU defs.
 >
 > Why?=A0 Most of the PVR definitions here can be removed (*muttering=20=
about
 >=A0 85xx ones being added).

Yeah, yeah, will work on removing them.

- kumar

_______________________________________________
Linuxppc-dev mailing list
 Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: James Chapman <jchapman@katalix.com>
Date: 2005-02-24 09:01:57

Tom Rini wrote:
On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
quoted
Signed-off-by: James Chapman <jchapman@katalix.com>

Trivial patch to add 7447A and 7457 CPU defs.

Why?  Most of the PVR definitions here can be removed (*muttering about
85xx ones being added).
I'm in the process of submitting a patch for a new board (Radstone
PPC7D). Since other boards test CPU type using definitions in this file,
I was trying to be consistent.

If the community don't think those definitions are useful, I'll just
move the ones I need into my board support stuff.

-- 
James Chapman
PGP key : http://www.katalix.com/~jchapman/pgpkey.txt

Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: Tom Rini <hidden>
Date: 2005-02-24 14:18:11

On Thu, Feb 24, 2005 at 09:01:50AM +0000, James Chapman wrote:
Tom Rini wrote:
quoted
On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
quoted
Signed-off-by: James Chapman <jchapman@katalix.com>

Trivial patch to add 7447A and 7457 CPU defs.

Why?  Most of the PVR definitions here can be removed (*muttering about
85xx ones being added).
I'm in the process of submitting a patch for a new board (Radstone
PPC7D). Since other boards test CPU type using definitions in this file,
I was trying to be consistent.

If the community don't think those definitions are useful, I'll just
move the ones I need into my board support stuff.
Is there something you can't get from cur_cpu_spec[0] ?  That's why all
of the PVR definitions _should_ be unneeded now.

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs

From: James Chapman <jchapman@katalix.com>
Date: 2005-02-24 15:50:49

Tom Rini wrote:
Is there something you can't get from cur_cpu_spec[0] ?  That's why all
of the PVR definitions _should_ be unneeded now.
No, I'll use cur_cpu_spec[]. Thanks

-- 
James Chapman
PGP key : http://www.katalix.com/~jchapman/pgpkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help