Thread (4 messages) 4 messages, 3 authors, 2004-12-09

Re: [PATCH] sungem rework & wake on lan

From: Colin Leroy <colin@colino.net>
Date: 2004-11-26 19:08:41

On 26 Nov 2004 at 14h11, Benjamin Herrenschmidt wrote:

Hi Ben, 

 	if (found_mii_phy(gp) && gp->phy_mii.def->ops->suspend)
-		gp->phy_mii.def->ops->suspend(&gp->phy_mii, 0 /* wake on lan options */);
+		gp->phy_mii.def->ops->suspend(&gp->phy_mii);

Shouldn't this if() have an "&& !wol" clause ?
At least it doesn't work without it, and works with it, here on 5221 PHY.

Thanks for your work. Will post a patch applying to 2.6.9+sleep_patch soon 
for the possibly interested people.

-- 
Colin
  http://www.colino.net/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help