Thread (6 messages) 6 messages, 3 authors, 2004-08-06

Re: Patch for debug setcontext

From: Corey Minyard <hidden>
Date: 2004-07-29 15:58:37

I misspoke a little.  Consider the following code in entry.S:

 #ifdef CONFIG_4xx
    /* Check whether this process has its own DBCR0 value */
    lwz    r0,PTRACE(r2)
    andi.    r0,r0,PT_PTRACED
    bnel-    load_4xx_dbcr0
 #endif

Do we need to add the book E define to this, too?

-Corey

Corey Minyard wrote:
Kumar Gala wrote:
quoted
I'm guessing, this should really be #if defined(CONFIG_4xx) ||
defined(CONFIG_BOOKE)
There are a number of similar cases later in this code as well.
That may be the case, but it is very confusing in entry.S.  The dbcr0
register seems to only be defined on 4xx processor, not on book E.
Look, for instance, at load_4xx_dbcr0:, it is only defined if 4xx is
enabled, not if book E is enabled.

-Corey

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help