Re: [PATCH] Make install target work

On Thu, Jun 17, 2004 at 12:38:22PM +0100, Martin Habets wrote:

On Wed, Jun 16, 2004 at 12:05:48PM -0700, Tom Rini wrote:

quoted

On Wed, Jun 16, 2004 at 07:16:52PM +0100, Martin Habets wrote:

quoted

This patch makes the install target work. After all, it is already
mentioned in the 'make help' output.
The only question is, should it install zImage by default? I always
install vmlinux, so I used that.

Given the number of different ways we have to deal with (this really
only handles pmac) I'd much rather just have boot/install.sh run either
the distribution or user-provided script.

Ehh.. that's exactly what install.sh tries to do! Only if both of these
do not exist will the bottom part of the code be executed.

Right.  And it's the bits at the bottom that I don't like.

The distribution provided scripts want an image to install. I agree
that it is impossible to supply the right image for all systems.
But maybe it is possible to echance this patch for some systems,
providing a different image based on config settings?

Possibly.  But I'm not convinced that the complexity will buy us
anything over the distribution script (which should cover all of the
pmac cases, if not, bug your distribution :)) and the user provided
hook.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/