On Fri, May 21, 2004 at 02:34:08PM -0500, Rune Torgersen wrote:

quoted

First, when this has come up in the past, the first question
is why is this useful, given that with the hardware and
peripherals in question, loadable drivers aren't really
useful (and don't shoot the messenger please).

Right now I mainly use it to debug a driver, which would run out of host
ram when I reloaded it

quoted

Second, you removed the EXPORT_SYMBOL for the old alloc, but
I didn't see quickly how a module would make use of the new
infrastructure since there weren't any new EXPORT_SYMBOLs.

This is because I did my patch against 2.6.5, and all the EXPORT sympols
are in arch/ppc/kernel/ppc_ksyms.c
and not in commprocs.c

In ppc_ksyms.c I have:
extern uint m8260_cpm_dpalloc(uint size, uint align);
extern uint m8260_cpm_hostalloc(uint size, uint align);
extern uint m8260_cpm_hostfree(uint ptr);
extern uint m8260_cpm_dpfree(uint ptr);

EXPORT_SYMBOL(m8260_cpm_dpalloc);
EXPORT_SYMBOL(m8260_cpm_hostalloc);
EXPORT_SYMBOL(m8260_cpm_dpfree);
EXPORT_SYMBOL(m8260_cpm_hostfree);

Er?  Aren't dpfree/hostfree new functions?  I didn't see them added as
exports in your patch, and regardless they belong in comproc.c now.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/