Re: [PATCH] fix build of ibmstb4 and ibmstbx25

On Wed, Sep 24, 2003 at 02:19:46PM -0700, Matt Porter wrote:

On Wed, Sep 24, 2003 at 11:00:07PM +0200, Andreas Oberritter wrote:

quoted

On Wed, 2003-09-24 at 19:17, Tom Rini wrote:

quoted

On Wed, Sep 24, 2003 at 05:04:49AM +0200, Andreas Oberritter wrote:

quoted

Hi Tom,

config.in.diff adds two missing '$' for config variables in
arch/ppc/config.in and the two other patches update the ocp definitions
for the stb4xxx and stbx25xx CPUs, so they can be built again. I used
linuxppc_2_4_devel, but they are needed for linuxppc-2.4, too.

Applied.  Does this mean you have the HW and can test things?

Thanks!

Yes, I have a set-top-box using the stb4500. I don't have an stbx25xx
yet, but there are or will be some interesting boxes on the market using
it.

I found two more bugs in linuxppc-2.4:

ppc405_wdt.c is missing, but it is available as a config option.

This one is in my queue to cleanup up and verify on 44x.  It
probably got missed since there aren't many users.

quoted

embed_config.c contains an #endif below #include <asm/io.h> without a
matching #if.

This fix is in a set of mismerge fixes I'm going to push RSN.

quoted

Unfortunately I can't send patches at the moment because my harddisk
died partially this morning...

Btw, thanks for applying the dbox2 patches! Will the watchdog code be
merged in before 2.4.23, too?

I was going to clean it up first.

I think he meant the dbox2 wdt changes.  Actually, I was hoping that you
would post the driver + needed changes to arch/ppc to lkml and see if
anyone comments on the code.
those

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/