Thread (1 message) 1 message, 1 author, 2002-11-19
  • (off-list ancestor, not in this archive)
  • Re: Fast HDLC driver · Roland Dreier <hidden> · 2002-11-19

Re: Fast HDLC driver

From: Roland Dreier <hidden>
Date: 2002-11-19 16:55:08

quoted
quoted
quoted
quoted
"Owen" == Owen Green [off-list ref] writes:
    Owen> most of them calls netif_rx from inside interrupt_handler (I
    Owen> don`t think this is the best place for doing that, watchdog
    Owen> may expire if the interface gets very busy..)

I don't have a specific answer about HDLC, but I think calling
netif_rx() from interrupt context is correct.  netif_rx() doesn't do
anything except queue the packet for processing and then mark the
network softirq.  In fact if you want to call netif_rx() from
non-interrupt context then you have to use the netif_rx_ni() function
to make sure the softirq runs soon enough.

Best,
  Roland

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help