Thread (3 messages) 3 messages, 3 authors, 2002-09-19

Re: undefined IRQs in request_irq

From: Paul Mackerras <hidden>
Date: 2002-09-19 00:49:11

Mark Chambers writes:
I wrote a driver for our custom MPC860 platform that we've ported linux 2.4.19
to.  When I insmod'd the driver it produced a kernel panic.  I traced it to
request_irq() in ppc8xx_pic.c, where the code calls panic() if the requested
irq is anything other than IDEx_INTERRUPT.  I fixed my problem by just adding
another case.

First, it seems extreme to me to crash the system instead of just refusing the
request.  Am I missing something?
No.  IMO the current request_8xxirq / request_irq stuff is completely
bogus.  I can understand it as a temporary construction while
debugging stuff, but it has long outlived its usefulness.  We should
just use request_irq for everything, request_8xxirq should die.

Paul.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help