Re: Execute Reset via CheckStop approach

From
Wolfgang Denk <hidden>
Date
2002-08-23 13:36:48
Hi,

in message [ref] you wrote:
I cleared CFG_DER in ppcboot to clear the CHSTP bit. After that I needed to
map in the br0 range and to make the asm's volatile and set the input/output
Why do you think you have to do this? This is _NOT_ necessary.
parameters of the asm to get the HRESET_N pulse. So this is the version
which works (on a MPC823e) in the context of the Linux kernel:

        /* Get base address mapped by BR0/OR0 and map it in */
        val = ((immap_t *)IMAP_ADDR)->im_memctl.memc_br0 & 0xFFFF8000;
	val = (int) ioremap( retval, 0x4000 );
This code is wrong. You clobber the value of "val" here.


Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd@denx.de
Defaults are wonderful, just like fire.
                  - Larry Wall in [off-list ref]

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Thread (1 message) 1 message, 1 author, 2002-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help