Thread (10 messages) 10 messages, 2 authors, 2002-05-01

Re: [PATCH] IBM ocp I2C

From: Armin <hidden>
Date: 2002-04-28 04:09:18

andrew may wrote:
On Fri, Apr 26, 2002 at 01:48:48PM -0700, Armin wrote:
quoted
quoted
In this patch I dump getown and getclock because they aren't
used and I am sure there is a better way to do things.
this does not work on Walnut since "procfreq" is not part of openbios
and the PLLMR does not exsist on the stb03 or 03  so this changes wont
go in.
I don't have a stb03 or even know what chip it uses, so I have
no idea what to do about it. We should have some generic 4xx
functions to get the CPU/PLB/OPB clocks so we can calculate what
the I2C div should be. We could always try trusing what the BIOS
sets the divider to as well.

Andrew,


I agree, the issue I have is that the clock solution was too arch/bios
specific and should reside somewhere outside the driver in the form of a
fuction or variable (as you suggest) that can take into accout the
differences in arch and possibly bios.

Thanks

armin


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help