Re: Problem in pmac PCI fixup
From: Michel Lanners <hidden>
Date: 2002-04-29 19:34:43
Attachments
- pci-irq.diff [text/plain] 4186 bytes · preview
From: Michel Lanners <hidden>
Date: 2002-04-29 19:34:43
Hi Ben, On 28 Apr, this message from Benjamin Herrenschmidt echoed through cyberspace:
quoted
--- linux-2.4.19-pre6-lvm-gentoo/arch/ppc/kernel/pmac_pci.c Sun Apr28 09:14:09 2002+++ linux-2.4.16-planb/arch/ppc/kernel/pmac_pci.c Sun Apr28 17:18:39 2002@@ -493,8 +503,6 @@ unsigned char pin; struct device_node* node; - if (pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin) ||!pin) - continue; /* No interrupt generated -> no fixup */ node = pci_device_to_OF_node(dev); if (!node) { printk("No OF node for device %x:%x\n", dev->bus-quoted
number, dev->devfn >> 3);Anybody have any problem with that approach?No problem with that, it's actually what we do in chrp.
Good then, can you apply the attached patch to any kernel tree within your reach :) ? I'll send off the Plan diff privately to you (it's quite a few K in size...). Cheers, and thanks Michel ------------------------------------------------------------------------- Michel Lanners | " Read Philosophy. Study Art. 23, Rue Paul Henkes | Ask Questions. Make Mistakes. L-1710 Luxembourg | email mlan@cpu.lu | http://www.cpu.lu/~mlan | Learn Always. "