Re: Incoming to helium.harhan.org:/home/linuxppc/linuxppc_2_4_alt
From: Tom Rini <hidden>
Date: 2002-04-09 14:52:22
On Mon, Apr 08, 2002 at 10:05:53AM -0700, Michael Sokolov wrote:
Tom Rini [off-list ref] wrote:quoted
We shouldn't be #ifdef'ing externs, since it doesn't matter. The pmac/prep/chrp ones were hidden just because the line above was, iirc.OK.quoted
And the one downside to the GENERIC_PPC32 platform_init, is that we're back to adding: #ifdef CONFIG_x case _MACH_x: x_init(...); break; #endifAnd what's wrong with that? It allows the user to make the kernel size vs. generality trade-off: you can have one machine supported or all of them.
Well, take a look at what the file used to look like in _devel. It was around 30-40 lines of that. Which is not nice to look at.
quoted
Which I think Paul was happy to see die :)But it's necessary, and it's a much better system than what you have now.
Well, it's a much better system if you want to group unlike hardware together in one kernel. :)
quoted
quoted
arch/ppc/config.in 1.127 02/03/31 23:58:43 msokolov@helium.harhan.org +18 -21 Add generic PPC32 config, implemented for Adirondack, EV-64260A, and K2Do any of these boards actually have an ISA slot?The boards I've used for this first implementation don't. But CONFIG_GENERIC_PPC32 is generic PPC32, not just these boards, and it should be possible for someone to support a machine with ISA slots under this generic framework.
Well, if ISA slots exist on the board, and should be working, they should just work. And when BenH merges in prep/chrp, it'll be needed. But the question is do you really want to offer this up on machines where it's not tested?
quoted
Right now it's an ALL_PPC-only option because it's actually needed for sound on some PReP boxes..And I'm hoping that some day PReP will be part of CONFIG_GENERIC_PPC32. See BenH's response about putting CONFIG_ALL_PPC to rest and converting to CONFIG_GENERIC_PPC32.
Right. -- Tom Rini (TR1265) http://gate.crashing.org/~trini/ ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/