Re: [PATCH] another for ibm_ocp_enet gzip'd

On Fri, Mar 15, 2002 at 02:25:42PM -0800, andrew may wrote:

On Fri, Mar 15, 2002 at 01:05:58PM -0700, Tom Rini wrote:

quoted

On Fri, Mar 15, 2002 at 11:41:37AM -0800, andrew may wrote:

quoted

3. added mal.sh to generate a new ibm_ocp_mal.c

This looks very cool.  Can you add in some comments to the shell script,
and I didn't see any bashisms in there, can you verify it works with
pdksh or one of the other script shells which can be /bin/sh ?

I am not sure how I can check against other shells since I don't
have them on my machine. Is sh --posix good enough?

It depends on what 'sh' is.

Here is a patch to mal.sh with some more comments, taking an
arg of the Mal count, and some spacing fixups.

Looks good.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/