Re: Incoming to hostme.bitkeeper.com:/ua/repos/p/ppc/linuxppc_2_4

On Fri, Aug 17, 2001 at 03:46:05PM +1000, Paul Mackerras wrote:

Tom Rini writes:

quoted

quoted

ChangeSet@1.272, 2001-08-16 10:22:52-07:00, trini@opus.bloom.county
  More minor changes to let !CONFIG_6xx compile again, arg!  Who
  knew the _{set,get}_L2CR bits were so heavily embedded? :)

Okay.  What I'm about to do in 2_4_devel, is try and rip these out a bit
more cleanly.  Right now, outside of platform-specific files, kernel/sysctl.c

Hmmm.  I think this is a situation where you need to realize that
you're digging yourself into a hole, stop, sit back and think about it
a bit more.

Well, alright.

You're wanting to remove code that isn't used on particular
platforms.  That's fine.  But then you get tripped up in all the
places where that code could be called.  You are solving that by
adding #ifdefs everywhere, which is the wrong answer.

Well, I've been trying to remove 'em actually.  What I ended up pushing
added 1 more #ifdef/#endif and removed 2 older ones from ppc_htab.c

quoted

can make use of L2CR stuffs.  Since we now have a change pending to Linus,
I want to make this file only care about proc_dol2crvec on CONFIG_6xx,
and likewise only compile in ppc_htab.c on CONFIG_6xx as well.  Right

As for /proc/ppc_htab, that is useful (despite its name) on systems
that don't use a hash table - there it gives info about TLB misses
IIRC.  It is also useful on power3/4 as well as 6xx.

Well, if I'm reading the htab code right, we -EFAULT on on !750/74xx.
I could be misinterpreting something, but I don't see it printing out
anything that isn't hashtable related.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/