Re: Kernel-2.4.7.pre5
From: Paul Mackerras <hidden>
Date: 2001-07-12 09:23:04
Jeff Garzik writes:
quoted
The "correct" fix would be somthing like that: /mirror/kernel/people/andrea/kernels/v2.4/2.4.7pre3aa1/00_ksoftirqd-7_ppc-2 But Paul was/is not very happy about that softirq thing...*shrug* linux-2.4.7-pre5 softirqs should finally (a) have a coherent implementation with no special cases, and (b) sort through all the bugs and API weirdness that Ingo added in 2.4.6-preXX.
I just looked and the 2.4.7-pre6 implementation looks OK to me. We do need the __ksoftirq_task field in the irq_cpustat_t structure. I remain unconvinced by some of the arguments for having the ksoftirqd thread(s). In particular the notion that you reduce your maximum stack usage that way is bogus - once the softirq is marked pending it will be executed the next time we take an interrupt, which means that it can be executed at any time that interrupts are enabled. But I don't think the current implementation is wrong, just a bit unnecessarily complex. As Jeff says, *shrug*. Paul. ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/